Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: datasource database role #2731

Merged
merged 11 commits into from
May 15, 2024

Conversation

mlorek
Copy link
Contributor

@mlorek mlorek commented Apr 19, 2024

Adding datasource - single database role

Test Plan

  • [ v] acceptance tests

References

@mlorek mlorek marked this pull request as ready for review April 19, 2024 12:41
@sfc-gh-asawicki
Copy link
Collaborator

Hey @mlorek. Thanks for the pull request. We will review it this week.

Copy link

gitguardian bot commented May 1, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.


resource snowflake_database_role "test_role" {
name = "%v"
comment = "test"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix formatting of Terraform config.

pkg/datasources/database_role.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR. We had a few suggestions, but after that we'll be good to merge 🙂.

pkg/datasources/database_role.go Outdated Show resolved Hide resolved
pkg/datasources/database_role.go Outdated Show resolved Hide resolved
pkg/datasources/database_role_acceptance_test.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, Thanks again for the contribution 🙂

@sfc-gh-jcieslak
Copy link
Collaborator

/ok-to-test sha=c223343d0b0102faa7ab8d16b2c8a9d362cab26e

"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
)

var databaseRoleSchema = map[string]*schema.Schema{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs have to be generated for this one, so just run make pre-push and the documentation should be generated. If any error pops up, refer to the contribution guidelines.

Copy link
Collaborator

@sfc-gh-jcieslak sfc-gh-jcieslak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref to the last comment

Copy link

Integration tests failure for c223343d0b0102faa7ab8d16b2c8a9d362cab26e

@sfc-gh-jcieslak
Copy link
Collaborator

/ok-to-test sha=e9108ff781c12a8d378d54ec8bdb8cf63ef7588d

Copy link

Integration tests failure for e9108ff781c12a8d378d54ec8bdb8cf63ef7588d

@sfc-gh-jcieslak
Copy link
Collaborator

/ok-to-test sha=7623db621e910b429a6be0f4e186fe2aafbd8bfb

Copy link

Integration tests failure for 7623db621e910b429a6be0f4e186fe2aafbd8bfb

3 similar comments
Copy link

Integration tests failure for 7623db621e910b429a6be0f4e186fe2aafbd8bfb

Copy link

Integration tests failure for 7623db621e910b429a6be0f4e186fe2aafbd8bfb

Copy link

Integration tests failure for 7623db621e910b429a6be0f4e186fe2aafbd8bfb

Copy link

Integration tests failure for 7623db621e910b429a6be0f4e186fe2aafbd8bfb

1 similar comment
Copy link

Integration tests failure for 7623db621e910b429a6be0f4e186fe2aafbd8bfb

@sfc-gh-jcieslak sfc-gh-jcieslak merged commit 319ddc3 into Snowflake-Labs:main May 15, 2024
7 of 8 checks passed
@sfc-gh-jcieslak
Copy link
Collaborator

Hey 👋
Everything looked great, the pr was merged. Again, thank you for your contribution!

sfc-gh-jmichalak pushed a commit that referenced this pull request May 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.91.0](v0.90.0...v0.91.0)
(2024-05-16)


### 🎉 **What's new:**

* add snowflake_grant_application_role resource
([#2690](#2690))
([838d241](838d241))
* datasource database role
([#2731](#2731))
([319ddc3](319ddc3))


### 🔧 **Misc**

* Add few documentation adjustments
([#2789](#2789))
([6db8bf3](6db8bf3))
* Bump dependencies
([#2802](#2802))
([54ea6bc](54ea6bc))
* Replace parsing function for saving granted object names
([#2813](#2813))
([175cfc7](175cfc7))


### 🐛 **Bug fixes:**

* Fix sweepers
([#2800](#2800))
([a01115e](a01115e))
* Invoke SetId immediately after alert creation
([#2786](#2786))
([181b4d0](181b4d0))
* Update the tests after snowflake bugfix
([#2806](#2806))
([6843c1a](6843c1a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants